Hi, On Sat, 6 May 2006, Junio C Hamano wrote: > Linus Torvalds <torvalds@xxxxxxxx> writes: > > > Finally, I think "git repo-config" is buggy. Try with this .config file: > > ... > > So we'd really be screwing with porcelain if we made them use this ;) > > Thanks Linus and Sean for bringing this up and fixing it. > > I have a vague feeling that this may not be the last breakage of > the repo-config command. My first reaction to the repo-config > code was "eek". It tries to reuse as much the existing material > as possible -- I understand it was done that way in order to > preserve the comments and blank lines from the original config > file intact, but it just felt very error prone (demonstrated by > cases like this and the other one Sean brought up) and generally > wrong. It was done because the very syntax of the config suggests it be a user-editable file. I do not want to mess with the comments more than necessary. > It might make sense to rewrite it to parse and read the existing > configuration as a whole, do necessary manupulations on the > parsed internal representation in-core, and write the result out > from scratch. That would fix another of my pet peeve: after an > invocation of repo-config to remove the last variable in a > section, it leaves an empty section header in. Does it really hurt? I think not. Anyway, I'll look into this. Ciao, Dscho - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html