On Sun, 16 Apr 2006, Junio C Hamano wrote: > > I am not sure if that belongs to diffstat flush. I was instead > planning to move it to diff-flush code Well, that's broken right now with the stat part, for some reason. > and show it only when we actually show any diffs. IOW, I think we would > want it even when we are doing "--pretty -p", not "--pretty > --patch-with-stat". I'd personally prefer to see it only in front of diffstat, and leave the patches the way they have been before. For patches, I find the indentation of the commit message to be visually (a) much more pleasing and (b) more pronounced than a "---" anyway. Perhaps configurable? git-format-patch doesn't want the indentation (and thus "---" makes sense for both patches and diffstat), while "git log" definitely does, because it's much more visually clear _and_ it makes the header/comment structure totally unambiguous. Linus - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html