On Sun, 16 Apr 2006, Junio C Hamano wrote: > > In the mid-term, I am hoping we can drop the generate_header() > callchain _and_ the custom code that formats commit log in-core, > found in cmd_log_wc(). Maybe. I'm not convinced, though. The reason? cmd_log_wc needs to generate it regardless, for the "always" case. Also, I think the "---" printing should be removed, and moved into the "diffstat" flushing code. Right now it does the wrong thing entirely if no diff exists, but we have always_show_header: it will print the "---" for no good reason. > I wish this "diff-tree SHA1 (from ANOTHERSHA1)" format can be > dropped and replaced with "commit SHA1" format like "git log" > does uniformly, but it might be already depended upon by > Porcelains. I think it might be worth just trying. A lot of the formats were pretty ad-hoc, and since everybody had their own routines, there was no reason to even try to keep them similar. Now, we'd be better off trying to make them look as close to each other as possible, and I suspect there's not a lot of porcelain that cares deeply about that format.. Linus - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html