Hi, On Sun, 2010-01-31 at 18:27 +0100, Martin Nordholts wrote: > In order to make a clear separation between the core modules and the > UI modules, move the necessary enums from display-enums.h and > widgets-enums.h to config-enums.h and the files > gimpdisplayoptions.[ch] from the display to the config module. This > removes the config -> display dependency. > > This change has three main benefits > * It lets us remove includes of display files from the config module > * We don't have to link gimp-console and test-config with a subset of > object files from the display module > * It is reflected in devel-docs/gimp-module-dependencies.svg that the > application is made up of core modules and UI modules and that no > core module depends on any UI module > --- > app/Makefile.am | 3 - > app/actions/view-actions.c | 2 +- > app/actions/view-commands.c | 2 +- > app/config/Makefile.am | 38 ++- > app/config/config-enums.c | 226 +++++++++++ > app/config/config-enums.h | 105 +++++ > app/config/config-types.h | 7 +- > app/config/gimpdisplayconfig.c | 9 +- > app/config/gimpdisplayconfig.h | 2 - > app/config/gimpdisplayoptions.c | 350 ++++++++++++++++ > app/config/gimpdisplayoptions.h | 72 ++++ > app/config/gimpguiconfig.h | 2 - > app/config/gimppluginconfig.h | 2 - > app/core/core-types.h | 3 - > app/display/Makefile.am | 2 - > app/display/display-enums.c | 124 ------ > app/display/display-enums.h | 49 --- > app/display/gimpdisplayoptions.c | 351 ---------------- > app/display/gimpdisplayoptions.h | 72 ---- > app/display/gimpdisplayshell-appearance.c | 3 +- > app/display/gimpdisplayshell-handlers.c | 2 +- > app/display/gimpdisplayshell.c | 2 +- > app/widgets/widgets-enums.c | 89 ---- > app/widgets/widgets-enums.h | 34 -- > devel-docs/gimp-module-dependencies.svg | 618 +++++++++++++++-------------- > 25 files changed, 1113 insertions(+), 1056 deletions(-) As far as I can see there are no enums with translations left in display-enums.h after your patch. So you could remove it from po/POTFILES.in. Other than that, the patch looks good. Even though I still don't quite follow your argumentation that it is an improvement, I won't object to this change. Sven _______________________________________________ Gimp-developer mailing list Gimp-developer@xxxxxxxxxxxxxxxxxxxxxx https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
