Sven Neumann wrote: > Hi, > > On Sat, 2009-02-07 at 23:03 +0100, Martin Nordholts wrote: > > >> So I can go ahead and revert this commit then? (rev 23135): >> >> 2007-08-07 Sven Neumann <sven@xxxxxxxx> >> >> * plug-ins/common/png.c (save_image): in the absence of an >> embedded color profile, write the sRGB chunk. >> > > I don't think we should do any code changes before we know exactly what > we want. I agree that someone should sit down and specify exactly how we want color management to work before doing major surgery. However, reverting that commit is not major surgery and to me writing an sRGB profile in the absence of an embedded profile is just plain wrong. If something like that was supposed to done it should at least be the RGB profile selected in the Color Management preferences, but even doing that would be making hasty assumptions. What if the user don't want a profile to be embedded in the PNG and does not want any gamma information to be saved either? It is IMO better to not write any color profile at all than to write one that might be wrong. Could you elaborate on why the change was made in the first place please? Maybe I miss something - Martin _______________________________________________ Gimp-developer mailing list Gimp-developer@xxxxxxxxxxxxxxxxxxxxxx https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
