Re: Code cleanup in unsharp-mask.c and possible speed enhancement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2009-01-15 at 08:43 +0100, Martin Nordholts wrote:
> Winston Chang wrote:
> > I took a look at the svn history of unsharp-mask.c (I'm the original
> > author) and saw that the fix for bug #166406 stopped using a lookup
> > table called ctable. This was because it slowed things down a lot for
> > large values of radius, due to cache overloading.
> > http://bugzilla.gnome.org/show_bug.cgi?id=166406
> >
> > After the fix, the lookup table is no longer being used for the
> > blurring algorithm, but it's still being generated and traversed
> > during the blur, so I have a patch that removes all that useless code,
> > without affecting functionality at all. What's the best way to submit
> > it, as I can't commit to the SVN repository?
> 
> 
> Hi!
> 
> I want to mention that since we are in the progress of migrating to GEGL
> we generally prefer that people make sure the GEGL counterpart works
> well rather than maintaining the legacy 8 bpc code. A patch for GEGL is
> much more attractive than a patch for an old GIMP plug-in.

There is no point in discouraging people from fixing / improving
code that will be in use for at least one or two more releases,
despite all GEGL goodness.

ciao,
--mitch


_______________________________________________
Gimp-developer mailing list
Gimp-developer@xxxxxxxxxxxxxxxxxxxxxx
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

[Index of Archives]     [Video For Linux]     [Photo]     [Yosemite News]     [gtk]     [GIMP for Windows]     [KDE]     [GEGL]     [Gimp's Home]     [Gimp on GUI]     [Gimp on Windows]     [Steve's Art]

  Powered by Linux