At 20:39 28.07.03 +0200, Sven Neumann wrote: >Hi, > >you've added a new file gimpwin32-io.h. Seems like a good idea but I'm >not sure if this header is supposed to be installed or not. I'm uncertain if it really should be installed or not, especially as nothing gets installed when I compile The Gimp or any plug-ins ... Though I'd rather like this header not be used (necessary) at all but it appeared to be better than just copy an pasting some missing defines once more. But it seemed there was something I don't understand : 2003-07-27 Henrik Brix Andersen <brix@xxxxxxxx> * app/base/tile-swap.c: re-added fallback definitions for _O_BINARY and _O_TEMPORARY Are there other platforms which do miss these defines? Which one? [If there are and the header should nake up some general lossage it definitely should _not_ be called gimpwin32-io.h.] >I definitely don't want it to be installed on win32 only. For now I did >the following changes to clean up your commit: > >2003-07-28 Sven Neumann <sven@xxxxxxxx> > > * libgimpbase/Makefile.am (EXTRA_HEADERS): added gimpwin32-io.h. > I still don't understand of enough automake, just guessing EXTRA_HEADERS =? install it (in /usr/include or prefix) EXTRA_DIST =? have it in the tar file (where it definitely should be to keep the source compileable cros platform. > * libgimpbase/gimpdatafiles.c: properly include the new header. > > >However I feel that since you are using the header from a plug-in, it >seems like it's generally useful and should probably be installed so >it can be used from third-party plug-ins as well. Perhaps the file >should even be included from libgimpbase.h ? > Having it to be in libgimbase.h looks wrong to me cause it is wrapping win32 system headers which probably should not be included everywhere : "Don't include headers in headers ..." Hans -------- Hans "at" Breuer "dot" Org ----------- Tell me what you need, and I'll tell you how to get along without it. -- Dilbert
