On Fri, 01 Aug 2003 14:56:23 -0300, "Joao S. O. Bueno" <gwidion@xxxxxxxxxx> wrote: > Maybe you could add some information about witch switches to use > on the diff command to create a suitable patch. > > I know that it may be well known for everyone here, but I for an > example, had to re-submit my first patch to the gimp because I've > created it without the -p switch. It should be emphasized that the best way to create a patch is to use "cvs diff" from a checked-out CVS tree. The paragraph that mentions this should remind the user that in order to use CVS efficiently, it is highly recommended to have a ~/.cvsrc file that contains at least the following settings: diff -up rdiff -up update -Pd checkout -P co -P get -P The next paragraph would say that those who do not use CVS should generate their patches with "diff -up" (and maybe -b or -w). It could even be more verbose and remind the user that the correct syntax is: diff -up old_file new_file > patch_file And if the patch affects multiple files, a recursive diff is necessary, using the original source tree as a reference (i.e., from the latest tarball) and a second copy of the source tree for the modified code: diff -rup old_source_tree modified_source_tree > patch_file -Raphaël