Re: [Gimp-developer] new tile-swap.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Tim Newsome <nuisance@xxxxxxxxxxxxxxxx> writes:

> A while back I wanted to open this huge satellite image I downloaded
> from NASA, and the Gimp required more than 2Gb of swap space. It
> didn't work, so I wrote a new tile-swap.c which makes additional
> swap files once the current one hits 1Gb. 

this shouldn't be necessary since the current code should handle large
swap files (see http://bugzilla.gnome.org/show_bug.cgi?id=74478).

> Also, the following diff
> needs to be aplpied:
> 
> --- gimp-1.3.7/app/base/tile-private.h  2001-12-03 05:44:50.000000000 -0800
> +++ gimp-1.3.7-tiles/app/base/tile-private.h    2002-08-03 18:59:37.000000000 -0
> 700
> @@ -76,7 +76,7 @@
>                        * for swapping. swap_num 1 is always the global
>                        * swap file.
>                        */
> -  off_t swap_offset;  /* the offset within the swap file of the tile data.
> +  guint64 swap_offset;/* the offset within the swap file of the tile data.
>                        * if the tile data is in memory this will be set to -1.
>                        */
>    TileLink *tlink;


IMO off_t is the correct type here. Since we use AC_SYS_LARGEFILE, off_t
should be 64 bits long if your OS supports such large files. guint64 is
definitely wrong since an offset should always be a signed value.


Salut, Sven


[Index of Archives]     [Video For Linux]     [Photo]     [Yosemite News]     [gtk]     [GIMP for Windows]     [KDE]     [GEGL]     [Gimp's Home]     [Gimp on GUI]     [Gimp on Windows]     [Steve's Art]

  Powered by Linux