David Odin <dindinx@xxxxxxxxxx> writes: > Hi, > > While trying to compile the current gimp CVS, gcc stops with the following > error: > /export4/Gimp/gimp/app/pdb/display_cmds.c:118: undefined reference to > `gdisplay_get_by_ID' > > I bet this is due to the recent gdisplay* ->gimp_display* changes from > Mitch. > > Since display_cmds.c is autogenerated, I guess I shouldn't edit this > file. > > The following patch fix the build: > --- gimp/tools/pdbgen/pdb.pl.orig Sun Nov 11 18:05:04 2001 > +++ gimp/tools/pdbgen/pdb.pl Sun Nov 11 18:05:36 2001 > @@ -38,7 +38,7 @@ > display => { name => 'DISPLAY', > type => 'GimpDisplay *', > headers => [ qw("display/gimpdisplay.h") ], > - id_func => 'gdisplay_get_by_ID', > + id_func => 'gimp_display_get_by_ID', > id_ret_func => '$var->ID' }, > image => { name => 'IMAGE', > type => 'GimpImage *', > > Should I commit it or Mitch, can you commit it yourself? Hi David, big OOPS :) and sorry... I have already checked in a slightly different fix which also replaces $var->ID by the new gimp_display_get_ID ($var). thanks, --Mitch