Hello all,
I just installed GIMP on my station, and I tried to make it save JPEGs
exactly as saved by IJG's software cjpeg. For that, I needed to strip the
comment field, because it was stored, even if it was the empty string. I
have fixed that problem with a small change.
I also tried to compile plug-ins/common/jpeg.c having GIMP_HAVE_PARASITES
#undefined. I could't because there was a section in source that was not
guarded by #ifdef GIMP_HAVE_PARASITES / #endif. I fixed that too.
It is the very first time when I try to send a patch to some GNU software,
so I don't know exactly how to do it. I sent this message to this List
now; if there is another, better way to contribute to contribute to GIMP,
I would like to know about it :-)
Please reply with Cc: cosmin@xxxxxxxxxxxxxx, as I am not subscribed to the
GIMP Developer List. Thank you.
Cosmin
Here is my patch:
*** plug-ins/common/jpeg.c~ Tue Feb 8 12:37:36 2000
--- plug-ins/common/jpeg.c Fri Feb 11 01:46:22 2000
***************
*** 1043,1049 ****
/* pw - Last of all, attach the parasites (couldn't do it earlier -
there was no image. */
!
if (!preview)
{
if (comment_parasite)
--- 1043,1050 ----
/* pw - Last of all, attach the parasites (couldn't do it earlier -
there was no image. */
!
! #ifdef GIMP_HAVE_PARASITES
if (!preview)
{
if (comment_parasite)
***************
*** 1057,1062 ****
--- 1058,1064 ----
parasite_free (vals_parasite);
}
}
+ #endif /* GIMP_HAVE_PARASITES */
return image_ID;
}
***************
*** 1382,1388 ****
jpeg_start_compress (&cinfo, TRUE);
/* Step 4.1: Write the comment out - pw */
! if (image_comment)
{
jpeg_write_marker (&cinfo,
JPEG_COM,
--- 1384,1390 ----
jpeg_start_compress (&cinfo, TRUE);
/* Step 4.1: Write the comment out - pw */
! if (image_comment && *image_comment)
{
jpeg_write_marker (&cinfo,
JPEG_COM,
