I am not convinced. The way it's done is fine in my opinion, mainly because it doesn't duplicate the implementation. What you suggest would be to create specialized meta operations foo-linear and foo-perceptual on top of foo with fixed "srgb" parameters and to hide foo... Right? I am not sure why this would help for anything, but I don't see anything wrong. And then it would be just a complement of what was suggested, still really easy to do :)
Kind regards,2014-09-05 13:02 GMT+02:00 Øyvind Kolås <pippin@xxxxxxxx>:
On Thu, Sep 4, 2014 at 9:48 PM, Teo Mazars
<mazarst@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
...
> add a "gamma-correction" toggle if needed (like the "srgb" boolean in over.
In this particular instance I would offer the opposite advice :).
Remove the "gamma-correction" toggle / "srgb" boolean, and create a
separate "gegl:over-perceptual" or "gegl:over-gamma" operation.
I consider what was done in GIMP with such sRGB booleans a hack; that
accidentally spread to the GEGL code base. From a GEGL
color-management perspective; over in linear light space; and over in
perceptual light space are two different (compositing) operations; and
from the perspective of applications using GEGL - it is easier to deal
with property/parameter-free compositors/layer-modes.
/pippin
_______________________________________________
gegl-developer-list mailing list
List address: gegl-developer-list@xxxxxxxxx
List membership: https://mail.gnome.org/mailman/listinfo/gegl-developer-list
_______________________________________________ gegl-developer-list mailing list List address: gegl-developer-list@xxxxxxxxx List membership: https://mail.gnome.org/mailman/listinfo/gegl-developer-list
