"Henderson, Stuart" <Stuart.Henderson@xxxxxxxxxx> writes: >>Ian: >> Hmmm, yeah, that is somewhat painful. >>If you want to fix this in uClibc, that's fine with me. >>I've CC'ed Richard Sandiford to confirm. However, it's not hard to >>imagine that, now that it works, somebody will expect to be able to use >>constants defined in insn-constants.h in ways that matter for libgcc2.c. >>So perhaps we should leave that as it is unless Richard thinks >>otherwise. > >>Richard: >>Actually, it was more than that. The idea was to allow target headers >>such as mips.h to use constants defined in .md files. This avoided >>some cases where the same constant or enum had to appear in both. > > > So if I'm to go ahead and fix this in uClibc, would a reasonable fix be to... > GCC: add -D__IN_LIBGCC2 to TARGET_LIBGCC2_CFLAGS in gcc/config/bfin/t-bfin-* > uClibc: include the enum in uClibc #ifndef __IN_LIBGCC2 > ? I would not accept that if I were a uClibc maintainer, but, sure, that seems fine from a gcc point of view. Ian
