Hi Petr,
thanks for checking and finding the issue of the test, it was really
helpful.
Acked-by: Andrea Cervesato <andrea.cervesato@xxxxxxxx>
Kind regards,
Andrea Cervesato
On 3/21/25 11:03, Petr Vorel wrote:
Test fails on XFS on kernel older than 5.10:
# ./ioctl_ficlone03
...
tst_test.c:1183: TINFO: Mounting /dev/loop0 to /tmp/LTP_ioc6ARHZ7/mnt fstyp=xfs flags=0
[ 10.122070] XFS (loop0): Superblock has unknown incompatible features (0x8) enabled.
[ 10.123035] XFS (loop0): Filesystem cannot be safely mounted by this kernel.
[ 10.123916] XFS (loop0): SB validate failed with error -22.
tst_test.c:1183: TBROK: mount(/dev/loop0, mnt, xfs, 0, (nil)) failed: EINVAL (22)
This also causes Btrfs testing to be skipped due TBROK on XFS. With increased version we get on 5.4 LTS:
# ./ioctl_ficlone03
tst_test.c:1904: TINFO: Tested kernel: 5.4.291 #194 SMP Fri Mar 21 10:18:02 CET 2025 x86_64
...
tst_supported_fs_types.c:49: TINFO: mkfs is not needed for tmpfs
tst_test.c:1833: TINFO: === Testing on xfs ===
tst_cmd.c:281: TINFO: Parsing mkfs.xfs version
tst_test.c:969: TCONF: The test requires kernel 5.10 or newer
tst_test.c:1833: TINFO: === Testing on btrfs ===
tst_test.c:1170: TINFO: Formatting /dev/loop0 with btrfs opts='' extra opts=''
[ 30.143670] BTRFS: device fsid 1a6d250c-0636-11f0-850f-c598bdcd84c4 devid 1 transid 6 /dev/loop0
tst_test.c:1183: TINFO: Mounting /dev/loop0 to /tmp/LTP_iocjwzyal/mnt fstyp=btrfs flags=0
[ 30.156563] BTRFS info (device loop0): using crc32c (crc32c-generic) checksum algorithm
[ 30.157363] BTRFS info (device loop0): flagging fs with big metadata feature
[ 30.158061] BTRFS info (device loop0): using free space tree
[ 30.158620] BTRFS info (device loop0): has skinny extents
[ 30.159911] BTRFS info (device loop0): enabling ssd optimizations
[ 30.160652] BTRFS info (device loop0): checking UUID tree
ioctl_ficlone03_fix.c:49: TPASS: invalid source : EBADF (9)
ioctl_ficlone03_fix.c:55: TPASS: invalid source : EBADF (9)
Fixing commit is 29887a2271319 ("xfs: enable big timestamps").
Signed-off-by: Petr Vorel <pvorel@xxxxxxx>
---
Hi all,
I suppose we aren't covering a test bug with this and test is really
wrong expecting 4.16 would work on XFS. FYI this affects 5.4.291
(latest 5.4 LTS which is still supported) and would not be fixed due a
lot of missing functionality from 5.10.
Kind regards,
Petr
testcases/kernel/syscalls/ioctl/ioctl_ficlone03.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/kernel/syscalls/ioctl/ioctl_ficlone03.c b/testcases/kernel/syscalls/ioctl/ioctl_ficlone03.c
index 6a9d270d9f..e2ab10cba1 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl_ficlone03.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl_ficlone03.c
@@ -113,7 +113,7 @@ static struct tst_test test = {
{.type = "bcachefs"},
{
.type = "xfs",
- .min_kver = "4.16",
+ .min_kver = "5.10",
.mkfs_ver = "mkfs.xfs >= 1.5.0",
.mkfs_opts = (const char *const []) {"-m", "reflink=1", NULL},
},
