On Wed, Mar 19, 2025 at 12:44:10PM -0400, Theodore Ts'o wrote: > On Wed, Mar 19, 2025 at 11:39:02PM +0800, Zorro Lang wrote: > > > > I've forgotten why I left g/699 to generic, not in overlay. Maybe > > Christian hope to run these two cases together in one FSTYP test > > round (don't need to run overlay test once). I'm good to move this > > case to tests/overlay/, cc Christian to check his review point. > > I had assumed it was because we might want to test the combination of > overlayfs with a variety of different underlying file systems? > > If we move this to tests/overlay, I'd still be able to do this kind of > testing via: > > {gce,kvm}-xfstests --primary-fstype {ext4,xfs} -c overlay/default -g auto > > This allows me to test overlayfs with the underlying upper and lower > directories being either ext4 or xfs. (I could and should extend this > to support other base file system types, via some minor changes to > test-appliance/files/root/fs/overlay/config, but I had never gotten > around to it.) > > How do other people who are testing overlayfs handle this? Hi Ted, Fstests supports overlayfs testing with different underlying fs, for example if you want to test overlay with ext4, you can set local.config as: FSTYP=ext4 TEST_DEV=/dev/sdb TEST_DIR=/mnt/test SCRATCH_DEV=/dev/sdc SCRATCH_MNT=/mnt/scratch then does: # mkfs.ext4 -F $TEST_DEV # mkfs.ext4 -F $SCRACH_DEV # mkdir /mnt/test # mkdir /mnt/scratch # ./check -overlay -g auto For more details you can refer to xfstests/README.overlay. Currently fstests only supports overlayfs testing as this, other fs, e.g. nfs, has to prepare nfs SCRATCH_DEV and TEST_DEV by the user. I'm thinking about supporting other upper fs testing likes overlay (if it's helpful). Thanks, Zorro > > - Ted > >