Re: [PATCH 5/8] btrfs/205: avoid test failure when running with nodatasum mount option

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Feb 12, 2025 at 05:01:53PM +0000, fdmanana@xxxxxxxxxx wrote:
> From: Filipe Manana <fdmanana@xxxxxxxx>
> 
> Currently the test fails when we pass "-o nodatasum" in MOUNT_OPTIONS and
> the reason is because we enable compression, with "chattr +c", on a file
> and then try to clone from it to a file with nodatasum inherited from the
> mount options, which results in the clone ioctl to fail with -EINVAL since
> it's not possible to clone from datasum to nodatasum and vice-versa.
> 
> Fix this by removing the "chattr +c", as it's not needed and we already
> exercise the compression scenario by explicitly cycle mounting the scratch
> device with "-o compress". This also allows us to exercise cloning the
> "foo1" file without compression. I originally added the "chattr +c" call
> but this was probably an oversight while debugging something.
> 
> Signed-off-by: Filipe Manana <fdmanana@xxxxxxxx>

Reviewed-by: David Sterba <dsterba@xxxxxxxx>




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux