[PATCH 5/8] btrfs/205: avoid test failure when running with nodatasum mount option

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



From: Filipe Manana <fdmanana@xxxxxxxx>

Currently the test fails when we pass "-o nodatasum" in MOUNT_OPTIONS and
the reason is because we enable compression, with "chattr +c", on a file
and then try to clone from it to a file with nodatasum inherited from the
mount options, which results in the clone ioctl to fail with -EINVAL since
it's not possible to clone from datasum to nodatasum and vice-versa.

Fix this by removing the "chattr +c", as it's not needed and we already
exercise the compression scenario by explicitly cycle mounting the scratch
device with "-o compress". This also allows us to exercise cloning the
"foo1" file without compression. I originally added the "chattr +c" call
but this was probably an oversight while debugging something.

Signed-off-by: Filipe Manana <fdmanana@xxxxxxxx>
---
 tests/btrfs/205 | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tests/btrfs/205 b/tests/btrfs/205
index 13a1df8b..71522492 100755
--- a/tests/btrfs/205
+++ b/tests/btrfs/205
@@ -21,7 +21,6 @@ _begin_fstest auto quick clone compress prealloc
 
 _require_scratch_reflink
 _require_xfs_io_command "falloc" "-k"
-_require_command "$CHATTR_PROG" chattr
 _require_btrfs_fs_feature "no_holes"
 _require_btrfs_mkfs_feature "no-holes"
 
@@ -33,7 +32,6 @@ run_tests()
     # extent. It has a file size of 128K.
     echo "Creating file foo1"
     touch $SCRATCH_MNT/foo1
-    $CHATTR_PROG +c $SCRATCH_MNT/foo1 > /dev/null 2>&1
     $XFS_IO_PROG -c "pwrite -S 0xab 0 4K" \
 		 -c "fsync" \
 		 -c "pwrite -S 0xab 4K 124K" \
-- 
2.45.2





[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux