> On Jan 7, 2025, at 00:30, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Mon, Jan 06, 2025 at 10:01:04PM +0800, Su Yue wrote: >> mkfs.ocfs2 is using 32bit journal as default. >> For 16T size device support, '-J block64' should be used. > > Hard coding this into a specific test is weird. I would expect > mkfs to pick the right one, but maybe the maintainers have a good > reason for not doing that? > Sounds more reasonable. 64bit journal support of ocfs2 was added in 2008, 17 gears agao... — Su > But if not you probably want to force it in your config file or > we need a workaround in _try_mkfs_dev. >