> On Jan 7, 2025, at 00:39, David Disseldorp <ddiss@xxxxxxx> wrote: > > Hi, > > On Mon, 6 Jan 2025 22:01:04 +0800, Su Yue wrote: > >> mkfs.ocfs2 is using 32bit journal as default. >> For 16T size device support, '-J block64' should be used. >> >> Signed-off-by: Su Yue <glass.su@xxxxxxxx> >> --- >> tests/generic/620 | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/tests/generic/620 b/tests/generic/620 >> index 3f1ce45a55fd..60e5a2cacdda 100755 >> --- a/tests/generic/620 >> +++ b/tests/generic/620 >> @@ -41,6 +41,9 @@ sectors=$((2*1024*1024*1024*17)) >> chunk_size=128 >> >> _dmhugedisk_init $sectors $chunk_size >> + >> +[ "$FSTYP" = "ocfs2" ] && MKFS_OPTIONS="$MKFS_OPTIONS -J block64" > > Makes sense, although as Christoph mentioned, a less test-specific > approach might be a better. E.g. _require_scratch_16T_support could skip My brain is clearer after one night sleep. As Christoph said, I think it’s problem of mkfs.ocfs2. Let me drop this patch. Thanks for your review. — Su > if block64 isn't configured, similar to ext4 (assuming tunefs.ocfs2 > provides a way to query for it, which I don't see at first glance). > > Cheers, David
