在 2024/12/18 03:52, Darrick J. Wong 写道:
On Tue, Dec 17, 2024 at 08:26:33AM +0000, Filipe Manana wrote:
On Tue, Dec 17, 2024 at 8:14 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
On Wed, Dec 11, 2024 at 03:09:40PM +0000, fdmanana@xxxxxxxxxx wrote:
The test also fails sporadically on xfs and the bug was already reported
to the xfs mailing list:
https://lore.kernel.org/linux-xfs/CAL3q7H7cURmnkJfUUx44HM3q=xKmqHb80eRdisErD_x8rU4+0Q@xxxxxxxxxxxxxx/
This version still doesn't seem to have the fs freeze/unfreeze that Darrick
asked for in that thread.
I don't get it, what's the freeze/unfreeze for? Where should they be placed?
Is it some way to get around the bug on xfs?
freeze kicks the background inode gc thread so that the unlinked clones
actually get freed before the swapon call. A less bighammer idea might
be to call XFS_IOC_FREE_EOFBLOCKS which also kicks the garbage
collectors.
I'm wondering why this GC things can not be done inside XFS' swapon call?
So that we don't need some per-fs workaround in a generic test case.
Thanks,
Qu
--D