On 12/10/24 1:53 AM, Christoph Hellwig wrote:
_require_scratch_duperemove doesn't check if the scratch file system
actually supports dedup, so add the proper call for that.
Signed-off-by: Christoph Hellwig <hch@xxxxxx>
---
Btw, I wonder if we should simply stop using dupremove in favor of the
xfs_io dedup command which seems lot less cumbersome? For now this is
a quick fix, though.
common/reflink | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/reflink b/common/reflink
index 22adc4449bc6..9177c45e70bb 100644
--- a/common/reflink
+++ b/common/reflink
@@ -83,6 +83,8 @@ _require_scratch_duperemove()
_scratch_mkfs > /dev/null
_scratch_mount
+ _require_scratch_dedupe
+
dd if=/dev/zero of="$SCRATCH_MNT/file1" bs=128k count=1 >& /dev/null
dd if=/dev/zero of="$SCRATCH_MNT/file2" bs=128k count=1 >& /dev/null
if ! "$DUPEREMOVE_PROG" -d "$SCRATCH_MNT/file1" \
Tested-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
--
Chuck Lever
