On Tue, Sep 17, 2024 at 6:20 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Mon, Sep 16, 2024 at 01:03:12PM +0100, fdmanana@xxxxxxxxxx wrote: > > Fix this by checking that the ioctl succeeded. > > The fixes look good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > What file do you manage to open but fail BLKSSZGET on here? This smells > like we have an issue in high level logic. I haven't hit any case where the ioctl failed. I was just saying that in case it fails, we may return an uninitialized/undefined value. > > And btrfs really should implement STATX_DIOALIGN with it's multi-device > setup that doesn't make the fallback very useful. > > >
