Re: [PATCH] fstests: fix min_dio_alignment logic for getting device block size

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Mon, Sep 16, 2024 at 01:03:12PM +0100, fdmanana@xxxxxxxxxx wrote:
> Fix this by checking that the ioctl succeeded.

The fixes look good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

What file do you manage to open but fail BLKSSZGET on here?  This smells
like we have an issue in high level logic.

And btrfs really should implement STATX_DIOALIGN with it's multi-device
setup that doesn't make the fallback very useful.

> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux