On Sat, Jul 20, 2024 at 9:38 AM Yang Erkun <yangerkun@xxxxxxxxxx> wrote: > > We use offset_readdir for tmpfs, and every we call rename, the offset > for the parent dir will increase by 1. So for tmpfs we will always > fail since the infinite readdir. Having an infinite readdir sounds like a bug, or at least an inconvenience and surprising for users. We had that problem in btrfs which affected users/applications, see: https://lore.kernel.org/linux-btrfs/2c8c55ec-04c6-e0dc-9c5c-8c7924778c35@xxxxxxxxxxx/ which was surprising for them since every other filesystem they used/tested didn't have that problem. Why not fix tmpfs? Thanks. > > Signed-off-by: Yang Erkun <yangerkun@xxxxxxxxxx> > --- > tests/generic/736 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/generic/736 b/tests/generic/736 > index d2432a82..9fafa8df 100755 > --- a/tests/generic/736 > +++ b/tests/generic/736 > @@ -18,7 +18,7 @@ _cleanup() > rm -fr $target_dir > } > > -_supported_fs generic > +_supported_fs generic ^tmpfs > _require_test > _require_test_program readdir-while-renames > > -- > 2.39.2 > >
