On Tue, Jun 18, 2024 at 11:15:42PM -0700, Christoph Hellwig wrote: > s/this test/these tests/ ? > > > + if echo "$MKFS_OPTIONS" | grep -q 'parent='; then > > + MKFS_OPTIONS="$(echo "$MKFS_OPTIONS" | sed -e 's/parent=[01]/parent=0/g')" > > Split the line? I also wonder if a generic helper to remove mkfs > options might be useful. Maybe when we get to the next caller? I'll split the line too. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks! --D
