On Mon, 8 Apr 2024 12:32:58 +0800, Anand Jain wrote:
> Btrfs-progs commit 5f87b467a9e7 ("subvolume: output the prompt line only
> when the ioctl succeeded") changed the output for snapshot command,
> updating the golden outputs.
>
> Create a helper filter to ensure the test cases pass on older btrfs-progs.
>
> Another option is to remove the 'btrfs subvolume snapshot' command output
> from the golden output and redirect it to /dev/null, but this strays from
> the bug-fix objective.
>
> Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx>
> ---
> v2: The missed testcases included now.
> Merged following two patches in v1:
> common/filter.btrfs: add a new _filter_snapshot
> btrfs: create snapshot fix golden output
Reviewed-by: David Disseldorp <ddiss@xxxxxxx>
I think retaining the golden output makes sense for this.
