On Fri, 9 Dec 2022 14:19:01 +0800, Qu Wenruo wrote: ... > --- a/tests/btrfs/080 > +++ b/tests/btrfs/080 > @@ -76,7 +76,7 @@ workout() > # created fs doesn't get that feature enabled. With it enabled, the below fsck > # call wouldn't fail. This feature hasn't been enabled by default since it was > # introduced, but be safe and explicitly disable it. > -_scratch_mkfs -O list-all 2>&1 | grep -q '\bno\-holes\b' > +_scratch_mkfs -O list-all 2>&1 | grep -q '\bno-holes\b' > if [ $? -eq 0 ]; then > mkfs_options="-O ^no-holes" > fi Looks good. I think I've hit this one too... Reviewed-by: David Disseldorp <ddiss@xxxxxxx>