On Mon, Jun 27, 2022 at 05:35:32PM +0800, Xiubo Li wrote:
<...>
> Sorry, could you give the link about this ?
>
> Checked the xfs/234, I didn't find any place is using the similar pattern.
>
> This is what I see:
>
> 53 # Now restore the obfuscated one back and take a look around
> 54 echo "Restore metadump"
> 55 xfs_mdrestore $metadump_file $TEST_DIR/image
> 56 SCRATCH_DEV=$TEST_DIR/image _scratch_mount
> 57 SCRATCH_DEV=$TEST_DIR/image _scratch_unmount
> 58
> 59 echo "Check restored fs"
> 60 _check_generic_filesystem $metadump_file
>
Doh! OK, you're right, looks like I'll need to change my glasses
graduation again.
>
> > Anyway, if you prefer, I'm fine sending v3 of this test doing something
> > like:
>
> Locally I just test this use case, it seems working as my guess.
That's odd. Here's the test I've used locally to confirm it works:
8<----------------------------------------------------------------
#!/bin/bash
MYVAR="HELLO"
myfunc()
{
echo "in function: $MYVAR"
}
MYVAR="$MYVAR WORLD" myfunc
MYVAR="$MYVAR WORLD" myfunc
myfunc
echo "$MYVAR"
8<----------------------------------------------------------------
When I run this in my laptop I see:
in function: HELLO WORLD
in function: HELLO WORLD
in function: HELLO
HELLO
Anyway, I think it's better to make this behaviour explicit in the test.
I'll send out v3 shortly. Thanks Xiubo.
Cheers,
--
Luís
