On Wed, 27 Apr 2022 at 14:18, Zorro Lang <zlang@xxxxxxxxxx> wrote: > > > diff --git a/common/rc b/common/rc > > index 553ae350..868b3ddd 100644 > > --- a/common/rc > > +++ b/common/rc > > [snip] > > > > > if [ -n "$type" -a "`_fs_type $dev`" != "$type" ]; then > > @@ -1869,6 +1890,7 @@ _require_test() > > if [ ! -d "$TEST_DIR" ]; then > > _notrun "this test requires a valid \$TEST_DIR" > > fi > > This place missed a ";;", it'll cause all cases fail directly when they try to > ". common/rc". As this patch has been RVB, I'll fix it when I merge it. But better > to give a patch a mimimum test before sending (except it's simple enough:), to make > sure it won't break the most fundamental things at least, it's hard for me to test > all fs that fstests supports before merging, Thanks for understanding :) > Sorry for the inconvenience. I guess I made a last minute error because normally I test my patch against CephFS. Should I be running more tests, besides just this one? Please let me know if so because I am new to xfstests-dev. I've resent my patch under subject "[PATCH test] common: add support for ceph-fuse". It should've been [PATCH v2] since it's a newer version of this patch but I guess I made a mistake while running "git send-email" (I'm new to it). Thanks for the patch review!
