On Tue, Apr 19, 2022 at 11:28:11PM +0530, Rishabh Dave wrote: > Currently tests in xfstests-dev can be executed against CephFS only by > mounting CephFS using kernel driver. Attempting to run tests against > CephFS using FUSE doesn't work because xfstests-dev would remount CephFS > using kernel. This patch adds the ability for xfstest-dev code to mount > CephFS using FUSE. > > Fixes: https://tracker.ceph.com/issues/55354 > Signed-off-by: Rishabh Dave <ridave@xxxxxxxxxx> > --- > common/config | 2 ++ > common/rc | 46 ++++++++++++++++++++++++++++++++++------------ > 2 files changed, 36 insertions(+), 12 deletions(-) > > diff --git a/common/config b/common/config > index 1033b890..efcf12e9 100644 > --- a/common/config > +++ b/common/config > @@ -556,6 +556,8 @@ _check_device() > _fatal "common/config: $name ($dev) is not a character device" > fi > ;; > + ceph-fuse) > + ;; > *) > _fatal "common/config: $name ($dev) is not a block device or a network filesystem" > esac > diff --git a/common/rc b/common/rc > index 553ae350..868b3ddd 100644 > --- a/common/rc > +++ b/common/rc [snip] > > if [ -n "$type" -a "`_fs_type $dev`" != "$type" ]; then > @@ -1869,6 +1890,7 @@ _require_test() > if [ ! -d "$TEST_DIR" ]; then > _notrun "this test requires a valid \$TEST_DIR" > fi This place missed a ";;", it'll cause all cases fail directly when they try to ". common/rc". As this patch has been RVB, I'll fix it when I merge it. But better to give a patch a mimimum test before sending (except it's simple enough:), to make sure it won't break the most fundamental things at least, it's hard for me to test all fs that fstests supports before merging, Thanks for understanding :) Thanks, Zorro > + ceph-fuse) > ;; > cifs) > echo $TEST_DEV | grep -q "//" > /dev/null 2>&1 > @@ -3204,7 +3226,7 @@ _check_test_fs() > virtiofs) > # no way to check consistency for virtiofs > ;; > - ceph) > + ceph|ceph-fuse) > # no way to check consistency for CephFS > ;; > glusterfs) > -- > 2.34.1 >
