On Mon, Aug 30, 2021 at 8:18 AM Nikolay Borisov <nborisov@xxxxxxxx> wrote:
>
>
>
> <snip>
> > Finally, this would also be a good opportunity to test regular renames
> > with subvolumes too, as we had bugs and regressions in the past like
> > in commit 4871c1588f92c6c13f4713a7009f25f217055807 ("Btrfs: use right
> > root when checking for hash collision
> > "), and never got any test cases for them.
>
> What specific tests do you have in mind? Ordinary renames of files
> within a subvolume are already tested by merit of generic geneirc/02[345].
So besides the case mentioned in that patch's changelog (renaming a
subvolume), checking that we can't rename an inode across subvolumes.
Something like checking that:
rename /mnt/subvol1/file /mnt/subvol2/file
fails with -EXDEV.
Thanks.
>
> The test in the patch you cited is basically renaming a subvolume within
> the same subvolume, that's easy enough.
>
> <snip>
--
Filipe David Manana,
“Whether you think you can, or you think you can't — you're right.”
