<snip> > Finally, this would also be a good opportunity to test regular renames > with subvolumes too, as we had bugs and regressions in the past like > in commit 4871c1588f92c6c13f4713a7009f25f217055807 ("Btrfs: use right > root when checking for hash collision > "), and never got any test cases for them. What specific tests do you have in mind? Ordinary renames of files within a subvolume are already tested by merit of generic geneirc/02[345]. The test in the patch you cited is basically renaming a subvolume within the same subvolume, that's easy enough. <snip>