On Wed, Jul 07, 2021 at 07:51:58AM -0700, Darrick J. Wong wrote: > # Skip this test unless the filesystem treats names (directory entries, > # fs labels, and extended attribute names) as raw byte sequences. > > > + case "$FSTYP" in > > + ext2|ext3|ext4|xfs|btrfs) > > Does this need to _notrun ext4 filesystems that have casefolding > enabled? (Or: should we let the ext4 developers figure that out?) Casefolding has to be enabled on the file system level (mkfs.ext4 -O casefold) but also on a per-directory level (by setting the casefold flag). Otherwise, unrestricted byte streams are allowed for file names. Since generic/453 doesn't set the casefold flag, this tests passes even when the scratch mount options include casefolding. The generic/556 test will test casefolding. BTW, we should probably include f2fs as a file system which normally allow unrestricted byte streams. F2fs also supports casefolding, but again, like ext4, it's only enabled when the per-directory casefold flag is enabled. So: + case "$FSTYP" in + ext2|ext3|ext4|f2fs|xfs|btrfs) I've verified that generic/453 passes on f2fs today. - Ted
