On Wed, Jul 07, 2021 at 12:20:07PM +0200, Pavel Reichl wrote:
> Running generic/453 test is probably only useful for filesystems that
> allow unrestricted byte streams for names.
>
> Signed-off-by: Pavel Reichl <preichl@xxxxxxxxxx>
> Suggested-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---
> common/rc | 11 +++++++++++
> tests/generic/453 | 1 +
> 2 files changed, 12 insertions(+)
>
> diff --git a/common/rc b/common/rc
> index d4ad421e..7a352445 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -4599,6 +4599,17 @@ _require_od_endian_flag()
> _notrun "od does not support endian flag"
> }
>
> +_require_names_are_bytes() {
This helper needs a short description.
# Skip this test unless the filesystem treats names (directory entries,
# fs labels, and extended attribute names) as raw byte sequences.
> + case "$FSTYP" in
> + ext2|ext3|ext4|xfs|btrfs)
Does this need to _notrun ext4 filesystems that have casefolding
enabled? (Or: should we let the ext4 developers figure that out?)
> + # do nothing
> + ;;
> + *)
> + _notrun "$FSTYP does now allow unrestricted byte streams for names"
> + ;;
> + esac
> +}
> +
> init_rc
>
> ################################################################################
> diff --git a/tests/generic/453 b/tests/generic/453
> index 55ddcc01..a0fb802e 100755
> --- a/tests/generic/453
> +++ b/tests/generic/453
> @@ -15,6 +15,7 @@ _begin_fstest auto quick dir
> # Import common functions.
>
> _require_scratch
> +_require_names_are_bytes
Do you need this for generic/454 as well?
--D
>
> echo "Format and mount"
> _scratch_mkfs > $seqres.full 2>&1
> --
> 2.31.1
>
