On Tue, Jun 01, 2021 at 03:31:52PM +0100, David Howells wrote: > Eryu Guan <guan@xxxxxxx> wrote: > > > _require_mknod checks for mknod support by trying to mknod and _notrun > > the test if mknod fails. > > > > So does afs return any failure like EOPNOTSUPP? If so I think we could > > refactor _require_mknod into something like > > afs doesn't provide a ->mknod implementation as it doesn't support anything > you'd create with it, so you get the VFS default in such an instance - which > would be EPERM. I think that works too. Currently _require_mknod() doesn't depend on the errno but just check if mknod succeeds or not. Thanks, Eryu