On 25/02/2021 11:18, Qu Wenruo wrote:
On 2021/2/25 上午11:15, Eric Sandeen wrote:
On 2/24/21 9:13 PM, Qu Wenruo wrote:
Now this makes way more sense,
Sorry for the earlier mistake.
as your previous comment on
_btrfs_forget_or_module_reload is completely correct.
_btrfs_forget_or_module_reload will really forget all devices, while
what we really want is just excluding certain devices, and not to affect
the other ones.
The proper way to fix it is to only introduce _btrfs_forget to
unregister involved devices, not all.
I'll take a look into the fix, but I'm afraid that, for systems which
don't support forget, they have to skip those tests and reduce the
coverage for older kernel/progs.
Can't you just rescan when the test is done?
Oh, that's way more simpler.
Thanks for the tip, I just over-engineered.....
Yep agreed.
on kernels with forget-ioctl,
btrfs dev scan --forget $SCRATCH_DEV_POOL
shall suffice.
However if we could define TEST_DEV_POOL="dev1 dev2 dev3" it will help
both old/new kernels. IMO.
_btrfs_forget_or_module_reload()
{
::
btrfs dev scan $TEST_DEV_POOL
}
Thanks, Anand
Thanks,
Qu
Thanks,
Qu
