On Mon, Oct 19, 2020 at 11:01:59AM +0800, Yang Xu wrote: > Here won't be "scratch mount failed" messages when mounting SCRATCH_DEV > failed, because _scratch_mount exits early by invoking the following_fail. > > _scratch_mount > { > _try_scratch_mount $* || _fail "mount failed" > } > > The message is useless and redundant. So drop it. > > Signed-off-by: Yang Xu <xuyang2018.jy@xxxxxxxxxxxxxx> > --- Looks good to me, Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --D > tests/generic/402 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/generic/402 b/tests/generic/402 > index 7fc81864..ddaadf6d 100755 > --- a/tests/generic/402 > +++ b/tests/generic/402 > @@ -102,7 +102,7 @@ run_test() > } > > _scratch_mkfs &>> $seqres.full 2>&1 || _fail "mkfs failed" > -_scratch_mount || _fail "scratch mount failed" > +_scratch_mount > > _require_timestamp_range $SCRATCH_DEV > > -- > 2.23.0 > > >