On Fri, Oct 16, 2020 at 08:33:21AM -0700, Darrick J. Wong wrote: > On Fri, Oct 16, 2020 at 05:31:24PM +0800, Yang Xu wrote: > > Here will check the return code of mount option. So update it > > to use _try_scratch_mount > > > > Signed-off-by: Yang Xu <xuyang2018.jy@xxxxxxxxxxxxxx> > > --- > > tests/generic/402 | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/generic/402 b/tests/generic/402 > > index 7fc81864..4c940ac4 100755 > > --- a/tests/generic/402 > > +++ b/tests/generic/402 > > @@ -102,7 +102,7 @@ run_test() > > } > > > > _scratch_mkfs &>> $seqres.full 2>&1 || _fail "mkfs failed" > > -_scratch_mount || _fail "scratch mount failed" > > +_try_scratch_mount || _fail "scratch mount failed" > > Why not just drop the "|| _fail" part? The message isn't much > more specific than the fail message that _scratch_mount emits. Agreed, using _scratch_mount is fine here. Thanks, Eryu
