Re: [PATCH 20/24] xfs/449: fix xfs info report output if realtime device specified

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Mon, Sep 14, 2020 at 06:45:02PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> Modify the mkfs.xfs output so that "realtime =/dev/XXX" becomes
> "realtime =external" so that the output will match xfs_db, which doesn't
> take a rt device argument and thus does not know.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---

Good to me,
Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>

>  tests/xfs/449 |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> 
> diff --git a/tests/xfs/449 b/tests/xfs/449
> index 83c3c493..938dbe28 100755
> --- a/tests/xfs/449
> +++ b/tests/xfs/449
> @@ -46,7 +46,9 @@ cat $tmp.mkfs >> $seqres.full
>  _scratch_xfs_db -c "info" > $tmp.dbinfo
>  echo DB >> $seqres.full
>  cat $tmp.dbinfo >> $seqres.full
> -diff -u $tmp.mkfs $tmp.dbinfo
> +# xfs_db doesn't take a rtdev argument, so it reports "realtime=external".
> +# mkfs does, so make a quick substitution
> +diff -u <(cat $tmp.mkfs | sed -e 's/realtime =\/.*extsz=/realtime =external               extsz=/g') $tmp.dbinfo
>  
>  _scratch_mount
>  
> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux