Re: [PATCH v4] xfs/191: update mkfs.xfs input results

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]





on 2020/03/31 15:49, Christoph Hellwig wrote:
On Mon, Mar 30, 2020 at 12:45:07PM +0800, Zorro Lang wrote:
+loopimg=$TEST_DIR/$seq.loopimg
+$XFS_IO_PROG -f -c "truncate $fssize" $loopimg
+loopdev=$(_create_loop_device $loopimg)
+SCRATCH_DEV=$loopdev

Hi,

I don't want to be picky, I think a "_require_test" would be better
if we use $TEST_DIR, although we always have a mounted TEST_DIR generally :)
If Eryu would like to add it, you can save one patch :)

Others looks good to me, test passed.
Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>

Same here, modulo a _require_test this looks good:
Thanks for your and zorro's review. I think Eryu can help me add _require_test when merge this patch into master.

Best Regards
Yang Xu

Reviewed-by: Christoph Hellwig <hch@xxxxxx>







[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux