On Mon, Mar 30, 2020 at 12:45:07PM +0800, Zorro Lang wrote: > > +loopimg=$TEST_DIR/$seq.loopimg > > +$XFS_IO_PROG -f -c "truncate $fssize" $loopimg > > +loopdev=$(_create_loop_device $loopimg) > > +SCRATCH_DEV=$loopdev > > Hi, > > I don't want to be picky, I think a "_require_test" would be better > if we use $TEST_DIR, although we always have a mounted TEST_DIR generally :) > If Eryu would like to add it, you can save one patch :) > > Others looks good to me, test passed. > Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx> Same here, modulo a _require_test this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
