On 2020/1/7 16:49, Amir Goldstein wrote:
> If keep_size is not supported, ops log can also includes the keyword
> "skip ..." by Eryu's patch:
> https://lore.kernel.org/fstests/20191022123115.12250-1-eguan@xxxxxxxxxxxxxxxxx/
>
> Do you want to add require support for keep_size/punch/zero/collapse and
> accept Eryu's patch as well?
>
I am perfectly fine with Eryu's patch and I think it is correct to merge it,
but it is completely independent to fixing the 4 tests.
Hi Eryu,
These 4 tests need the exact operations to reproduce some issues by
--replay-ops so Amir perfer to skip tests rather than one operation
if a required operation/flag in tests is not supported.
I think it is reasonable to skip these tests in the case so I have sent
v3 patch set[1][2]:
https://www.spinics.net/lists/fstests/msg13290.html
https://www.spinics.net/lists/fstests/msg13291.html
With my v3 patch set, it seems that these 4 tests have no chance to fall
into the condition described by your patch:
https://lore.kernel.org/fstests/20191022123115.12250-1-eguan@xxxxxxxxxxxxxxxxx/
Best Regards,
Xiao Yang
