On 2020/1/7 14:47, Amir Goldstein wrote:
No it is not wrong, but this is different than skipping keep_size.
My point is that when fsx is run with some parameters and
produces a replay-ops log. If that replay-ops log is replayed with
exact same parameters it should produce the exact same sequence.
In the case of punch/zero/collapse, if those are skipped when recording
the ops log, then ops log includes the keyword "skip ..." explicitly, but
but for skipped keep_size, keep_size will simply not be in the log.
Hi Amir,
If keep_size is not supported, ops log can also includes the keyword
"skip ..." by Eryu's patch:
https://lore.kernel.org/fstests/20191022123115.12250-1-eguan@xxxxxxxxxxxxxxxxx/
Do you want to add require support for keep_size/punch/zero/collapse and
accept Eryu's patch as well?
Thanks,
Xiao Yang
IOW, the fsxops logs that are hardcoded in the 4 tests that you changed
have all been created*with* keep_size support and*with* punch/zero/collapse
support, so should also be replayed the same way, because otherwise the test
is simply not doing what it was intended to do.
