On 1/21/19 5:53 PM, Dave Chinner wrote: > On Mon, Jan 21, 2019 at 11:33:12AM -0500, jeffm@xxxxxxxx wrote: >> From: Jeff Mahoney <jeffm@xxxxxxxx> >> >> e2fsprogs versions prior to v1.42.7 had a different format for >> filefrag -v that is incompatible with the regex in _filefrag_filter. >> >> This patch adds support for the older format to test on older releases > > Can you document what the two formats are in a comment just so it is > somewhat easier to check the regexes are, indeed, doing the right > thing? Sure. That's easy enough. -Jeff -- Jeff Mahoney SUSE Labs