On Mon, May 21, 2018 at 09:06:48AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
>
> If this test runs successfully, it'll leave a shutdown scratch fs
> behind. The test framework doesn't unmount the fs for us (because we
> told it not to check the fs) so the test framework tries to "test -d
> $SCRATCH_MNT" and blows up on the IO error it receives from the dead fs.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---
> tests/xfs/132 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/xfs/132 b/tests/xfs/132
> index 6bb03e79..3fa695a7 100755
> --- a/tests/xfs/132
> +++ b/tests/xfs/132
> @@ -67,6 +67,7 @@ _scratch_mount
>
> # The corrupt inode should be tripped over during these initial file creates.
> touch $SCRATCH_MNT/file{0,1,2,3,4,5}{0,1,2,3,4,5} 2>&1 | _filter_scratch
> +_scratch_unmount
I've already NAK'd that patch - the test harness should be
unmounting scratch in all situations and returning the test harness
to a known initial state before the next test runs...
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
