From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> The comment about the dmerror switcheroo is hard to understand and wrong. Fix both problems by rewriting it. Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --- tests/generic/475 | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/generic/475 b/tests/generic/475 index e31f1251..45072278 100755 --- a/tests/generic/475 +++ b/tests/generic/475 @@ -73,9 +73,11 @@ for i in $(seq 1 $((50 * TIME_FACTOR)) ); do # recovery sleep $((RANDOM % 3)) - # Loading error table without "--nolockfs" option. Because "--nolockfs" - # won't freeze fs, then some running I/Os may cause XFS to shutdown - # prematurely. That's not what we want to test. + # This test aims to simulate sudden disk failure, which means that we + # do not want to quiesce the filesystem or otherwise give it a chance + # to flush its logs. Therefore we want to call dmsetup with the + # --nolockfs parameter; to make this happen we must call the load + # error table helper *without* 'lockfs'. _dmerror_load_error_table ps -e | grep fsstress > /dev/null 2>&1 -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
