Re: [PATCH] xfs/132: umount scratch device after finishing test

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Sat, May 19, 2018 at 12:32:24PM +0800, Xiao Yang wrote:
> xfs/132 and xfs/133 running together got the following error:
> ------------------------------------------------------------
> ...
> xfs/132 1s ... 1s
> xfs/133 1s ... [failed, exit status 1] - output mismatch (see /var/lib/xfstests/results//xfs/133.out.bad)
> ...
> QA output created by 133
> -Format and mount
> -Corrupt filesystem
> -Remount, try to append
> -Write did not succeed (ok).
> +SCRATCH_DEV=/dev/sda11 is mounted but not on SCRATCH_MNT=common/config: - aborting
> +Already mounted result:
> +/dev/sda11 /mnt/xfstests/scratch
> ...
> ------------------------------------------------------------
> 
> xfs/132 led to XFS shutdown due to the corrupted inode, but it didn't rectify XFS
> by umount scratch device.

AFAIK, we don't have to unmount the scratch device when a test
finishes - the test harness is supposed to do that and make sure
that it is in the correct state for the next test to run.

It seems that somewhere along the line this got broken. - I'm
guessing the fact that this test also says "don't check the scratch
device" the test harness is failing to unmount it because it's not
running _check_scratch_device. I'm guessing that it should at least
run _scratch_unmount....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux