On Sun, May 20, 2018 at 02:45:17PM -0400, Theodore Ts'o wrote: > generic/490 fails because cleanup tries to delete . and .. since $tmp > is left unset, and so "rm -f $tmp.*" does nothing useful. Instead > delete temp files created by seek_sanity_test. > > Signed-off-by: Theodore Ts'o <tytso@xxxxxxx> Sorry, this is my bad, Jan's original patch did just remove the test files, I intended to use lower case variable name but did wrong update in _cleanup(). Thanks for the fix! Eryu > --- > tests/generic/490 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/generic/490 b/tests/generic/490 > index b5042c2e..c0335ca0 100755 > --- a/tests/generic/490 > +++ b/tests/generic/490 > @@ -49,7 +49,7 @@ _require_test_program "seek_sanity_test" > _cleanup() > { > cd / > - rm -f $tmp.* > + rm -f $base_test_file* > } > > $here/src/seek_sanity_test -s 19 -e 20 $base_test_file > $seqres.full 2>&1 || > -- > 2.16.1.72.g5be1f00a9a > -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html