On Sat, May 05, 2018 at 09:55:54AM +0300, Amir Goldstein wrote:
> On Sat, May 5, 2018 at 3:19 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> >
> > Also document the new way to run all tests (i.e. check -g all) and
> > clean up all the stray whitespace in the readme file.
> >
> > Signed-Off-By: Dave Chinner <dchinner@xxxxxxxxxx>
> [...]
> > + and it excludes tests that exercise conditions known to cause machine
> > + failures (i.e. the "dangerous" tests).
>
> That would have been nice.. if it was implemented...
>
> I counted 22 dangerous tests, 20 of which are in auto group, unlike the
> 87 dangerous_* tests, none of which are in auto group.
The 'dangerous' group and 'auto' group are not mutually exclusive when
it was introduced, see commit 3f28d55c3954 ("add freeze and dangerous
groups"). But from previous discussions[1][2], they should be mutually
exclusive.
[1] https://www.spinics.net/lists/fstests/msg08652.html
[2] https://www.spinics.net/lists/fstests/msg08663.html
>
> If running ./check would exclude 'dangerous' tests by default, should it
> also exclude dangerous_* tests? Or should we just remove the 20
> 'dangerous' tests from auto group and try not to add new auto&dangerous
> tests in the future?
I agreed, I think we should just remove the 20 'dangerous' tests from
auto group (AFAICT, they are not dangerous anymore). And I'll avoid
adding new tests that are in both dangerous & auto group.
Thanks,
Eryu
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
