On Mon, Mar 26, 2018 at 09:22:53AM +0800, Eryu Guan wrote: > On Fri, Mar 23, 2018 at 09:08:17AM -0700, Darrick J. Wong wrote: > > > > + > > > > + # Format filesystem > > > > + echo "TEST $cmd" | tee /dev/ttyprintk > > > > > > What's the purpose of writing to /dev/ttyprintk? I don't see how it's > > > used in the test. > > > > It makes it easy to tell which kernel messages came from which runtest() > > invocation so that we can tell if a particular agfl mutation test > > actually triggered the fixup. > > This could fail the test if /dev/ttyprintk doesn't exist. It seems Correction, it doesn't fail the test, but creates a new /dev/ttyprintk file.. but still, I think this should be addressed. Rather than that, the test runs good for me, it fails with 4.16-rc7 kernel and passes with the mentioned patch applied. Brian, would you please help review the new version of this patch in patchset "[PATCH 0/4] misc. fstests changes" (patch 3/4) as well? I really like a Reviewed-by tag from someone who knows all the details of the test and the fix :) Thanks a lot! Eryu > writing to /dev/kmsg works could tell us the same information, and we've > already made sure /dev/kmsg is writable by _require_check_dmesg. IMHO > /dev/kmsg might be a better choice here. > > Thanks, > Eryu -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
